feat: color selection based on angle with widget#4389
Open
livethg wants to merge 2 commits into
Open
Conversation
Signed-off-by: Thomas Gauthier <thomgau17@gmail.com>
Signed-off-by: Thomas Gauthier <thomgau17@gmail.com>
Member
|
Thanks for the PR. This is an interesting approach. I just wonder how it behaves on touch devices. We have users that use Flameshot on tablets and touch screens, and as far as I understand, the concept of holding right-click depends on the interface. In those with pen/stylus, this is typically easier than those using their fingers. Alternatively, this can be something to be configured by the user. I'm interested to know @borgmanJeremy opinion over this PR. If/when @borgmanJeremy approves, we can ask as for feedback from the community who use tablets and touch devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current process for selecting a new colour requires opening the colour picker with a right click and then selecting a colour with a left click on the chosen disk. This quickly become tedious when multiple colours are involved in the drawing.
This pull request aims to fix this issue by having the colour picker chose the colour that corresponds to the current orientation of the cursor, removing the requirement for a second mouse press.
This also fixes an inconvenience (possibly a bug) where if no tool is selected and the wheel is spawned on the sides of the selection panel, when choosing a colour outside the bounds of the selection, the selection will consider the left click as a new selection, effectively removing the previous selection area.