feat(aria-snapshot): expose aria-invalid in ARIA snapshots#40966
Open
adityasingh2400 wants to merge 1 commit into
Open
feat(aria-snapshot): expose aria-invalid in ARIA snapshots#40966adityasingh2400 wants to merge 1 commit into
adityasingh2400 wants to merge 1 commit into
Conversation
Form-validation tests with ARIA snapshots could not assert on the invalid state of an input, because `aria-invalid` was not surfaced in the snapshot at all. Add an `invalid` boolean prop mirroring the existing `checked` / `disabled` / `expanded` / `level` / `pressed` shape, and emit `[invalid]` next to the role for elements whose role appears in the WAI-ARIA 1.2 list of roles that support `aria-invalid`. Treats `aria-invalid="true" | "grammar" | "spelling"` as `true` for snapshot purposes; the distinct values are still available through the existing `getAriaInvalid` helper for accessibility tree consumers. Fixes: microsoft#34839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-invalidin ARIA snapshots so form-validation tests can assert on the invalid state. Adds aninvalidboolean prop next to the existingchecked/disabled/expanded/level/pressedshape, and emits[invalid]for elements whose role is in the WAI-ARIA 1.2 list (textbox,combobox,checkbox,radiogroup,spinbutton, etc.).aria-invalid="true" | "grammar" | "spelling"all map to the boolean flag for snapshot purposes; the distinct values remain available through the existinggetAriaInvalidhelper for accessibility consumers.Fixes #34839